Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check referential dependencies on DROP TABLE #45936

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Check referential dependencies on DROP TABLE #45936

merged 1 commit into from
Feb 10, 2023

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented Feb 1, 2023 •
edited

Changelog category:

  • Improvement

Changelog entry:

Add setting check_referential_table_dependencies to check referential dependencies on DROP TABLE.
This PR solves #38326

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-improvement Pull request with some product improvements label Feb 1, 2023
@vitlibar vitlibar force-pushed the add-setting-check-referential-deps-on-drop branch 2 times, most recently from ad04c2e to 448b67d Compare February 2, 2023 09:48
@tavplubix tavplubix self-assigned this Feb 2, 2023
@vitlibar vitlibar force-pushed the add-setting-check-referential-deps-on-drop branch from d02fcd0 to 5a58a2b Compare February 4, 2023 17:56
@vitlibar vitlibar marked this pull request as draft February 5, 2023 20:21
@vitlibar vitlibar added the do not test disable testing on pull request label Feb 5, 2023
@vitlibar vitlibar changed the title Check referential dependencies on DROP TABLE [WIP] Check referential dependencies on DROP TABLE Feb 5, 2023
@vitlibar vitlibar force-pushed the add-setting-check-referential-deps-on-drop branch from 5a58a2b to d0f47bf Compare February 5, 2023 20:23
@vitlibar
Copy link
Member Author

vitlibar commented Feb 5, 2023 •
edited

This PR requires #46058 and #46138 to be merged first otherwise the tests will fail.

@vitlibar vitlibar force-pushed the add-setting-check-referential-deps-on-drop branch from e4ab330 to 4869d38 Compare February 8, 2023 23:06
@vitlibar vitlibar removed the do not test disable testing on pull request label Feb 8, 2023
@vitlibar vitlibar changed the title [WIP] Check referential dependencies on DROP TABLE Check referential dependencies on DROP TABLE Feb 8, 2023
@vitlibar vitlibar marked this pull request as ready for review February 8, 2023 23:06
@tavplubix
Copy link
Member

Integration tests (asan) [4/6] - #45160 and #43754

@tavplubix tavplubix merged commit 8eae498 into ClickHouse:master Feb 10, 2023
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees

@tavplubix tavplubix

Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitlibar @tavplubix @robot-ch-test-poll2