-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix named collections access #46010
Merged
kssenii
merged 8 commits into
ClickHouse:master
from
kssenii:named-collections-fix-access
Feb 7, 2023
Merged
Fix named collections access #46010
kssenii
merged 8 commits into
ClickHouse:master
from
kssenii:named-collections-fix-access
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-2
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Feb 3, 2023
kssenii
force-pushed
the
named-collections-fix-access
branch
from
February 3, 2023 12:16
12732d3
to
fd9cd85
Compare
kssenii
force-pushed
the
named-collections-fix-access
branch
from
February 3, 2023 12:19
fd9cd85
to
486c10b
Compare
kssenii
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Feb 3, 2023
…to named-collections-fix-access
kssenii
force-pushed
the
named-collections-fix-access
branch
from
February 4, 2023 22:33
0555cdb
to
84ea48b
Compare
kssenii
force-pushed
the
named-collections-fix-access
branch
from
February 5, 2023 12:39
d3e9c3b
to
3042e9e
Compare
kssenii
force-pushed
the
named-collections-fix-access
branch
from
February 6, 2023 10:35
c5ebd29
to
631c460
Compare
kssenii
added
pr-backward-incompatible
Pull request with backwards incompatible changes
and removed
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-bugfix
Pull request with bugfix, not backported by default
labels
Feb 6, 2023
tests/integration/test_named_collections/configs/users.d/users_no_default_access2.xml
Outdated
Show resolved
Hide resolved
SmitaRKulkarni
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest all LGTM
kssenii
force-pushed
the
named-collections-fix-access
branch
from
February 7, 2023 12:02
64b89f5
to
022d430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Default user will not have permissions for access type
SHOW NAMED COLLECTION
by default (e.g. by default, default user will not longer be able to do grant ALL to other users as it was before, therefore this PR is backward incompatible).