Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named collections access #46010

Merged
merged 8 commits into from
Feb 7, 2023

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented Feb 3, 2023

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Default user will not have permissions for access type SHOW NAMED COLLECTION by default (e.g. by default, default user will not longer be able to do grant ALL to other users as it was before, therefore this PR is backward incompatible).

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 3, 2023
@kssenii kssenii force-pushed the named-collections-fix-access branch from 12732d3 to fd9cd85 Compare February 3, 2023 12:16
@kssenii kssenii force-pushed the named-collections-fix-access branch from fd9cd85 to 486c10b Compare February 3, 2023 12:19
@kssenii kssenii added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Feb 3, 2023
@kssenii kssenii force-pushed the named-collections-fix-access branch from 0555cdb to 84ea48b Compare February 4, 2023 22:33
@kssenii kssenii force-pushed the named-collections-fix-access branch from d3e9c3b to 3042e9e Compare February 5, 2023 12:39
@SmitaRKulkarni SmitaRKulkarni self-assigned this Feb 6, 2023
@kssenii kssenii force-pushed the named-collections-fix-access branch from c5ebd29 to 631c460 Compare February 6, 2023 10:35
@kssenii kssenii added pr-backward-incompatible Pull request with backwards incompatible changes and removed pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-bugfix Pull request with bugfix, not backported by default labels Feb 6, 2023
Copy link
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest all LGTM

@kssenii kssenii force-pushed the named-collections-fix-access branch from 64b89f5 to 022d430 Compare February 7, 2023 12:02
@kssenii kssenii merged commit a5d3b00 into ClickHouse:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backward-incompatible Pull request with backwards incompatible changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants