Improve behaviour of conversion into Date for boundary value 65535 - … #46042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-2
added
the
pr-improvement
jh0x
force-pushed
the
improve-into-date-from-uint16
branch
from
f43b8de
to
e1f345c
Compare
pufit
approved these changes
Feb 9, 2023
|
test_merge_tree_s3_failover/test.py::test_move_failover flaky #46230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43370 describes a bit weird behaviour when dealing with column of
DatetypeFor
Date(underlyingUInt16) we have:I think the behaviour after the fix is more consistent.
Closes #43370
Previous fix (#45914) had to be reverted - as one of the tests was written in a way that broke in some of the timezones.
In that test I was converting
65536toDate-> and this invokes timezone aware conversion (time_zone.toDayNum(std::min(time_t(from), time_t(0xFFFFFFFF)))-> which resulted in either1970-01-01or1970-01-02. The test has now be rewritten to avoid the problems.I had tested a mix of the following timezones:
TZ=Australia/Brisbane,TZ=America/Chicago,TZ=Europe/London,TZ=Pacific/Tarawa.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improve behaviour of conversion into Date for boundary value 65535 (2149-06-06)
Documentation entry for user-facing changes