Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smallish follow-up to #46057 #46072

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Smallish follow-up to #46057 #46072

merged 1 commit into from
Feb 7, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Feb 6, 2023

Follow-up to #46057:

  • Add TODO comment to MultiVersion.h
  • Ctor requires no atomic op

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 6, 2023
@evillique evillique self-assigned this Feb 6, 2023
@rschu1ze rschu1ze merged commit f9b6c10 into master Feb 7, 2023
@rschu1ze rschu1ze deleted the rs/follow-up-to-46057 branch February 7, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rschu1ze @evillique @robot-clickhouse-ci-1