Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parts, active_parts total_marks to system.tables #46161

Merged
merged 31 commits into from
Feb 12, 2023
Merged

add parts, active_parts total_marks to system.tables #46161

merged 31 commits into from
Feb 12, 2023

Conversation

attack204
Copy link
Contributor

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add parts, active_parts and total_marks columns to system.tables on issue

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Feb 8, 2023
@ucasfl ucasfl added the can be tested Allows running workflows for external contributors label Feb 8, 2023
ucasfl
ucasfl reviewed Feb 8, 2023
View reviewed changes
src/Storages/IStorage.h Outdated Show resolved Hide resolved
@CheSema CheSema self-assigned this Feb 9, 2023
CheSema
CheSema approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@CheSema CheSema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest are LGTM

attack204 and others added 2 commits February 10, 2023 21:14
@attack204 @ucasfl
Update src/Storages/MergeTree/MergeTreeData.cpp
7664114 
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
@attack204 @ucasfl
Update src/Storages/MergeTree/MergeTreeData.cpp
d31457d 
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
@CheSema
Copy link
Member

CheSema commented Feb 10, 2023

test_storage_rabbitmq -- #45160
00738_lock_for_inner_table -- #46210
02122_parallel_formatting_JSONCompact -- stateless, health check -- #40410

@alexey-milovidov alexey-milovidov self-assigned this Feb 12, 2023
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 merged commit 4217e65 into ClickHouse:master Feb 12, 2023
@attack204 attack204 deleted the addParts branch February 12, 2023 10:00
@ucasfl ucasfl mentioned this pull request Mar 9, 2023
Closed
@alexey-milovidov alexey-milovidov mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucasfl ucasfl ucasfl left review comments

@CheSema CheSema CheSema approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

@CheSema CheSema

Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@attack204 @CheSema @alexey-milovidov @ucasfl @robot-clickhouse @robot-clickhouse-ci-1