Remove excessive license notices from preciseExp10.cpp #46163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-build
| @@ -3,9 +3,7 @@ | |||
| /** exp10 from GNU libm fails to give precise result for integer arguments. | |||
| * For example, exp10(3) gives 1000.0000000000001 | |||
| * despite the fact that 1000 is exactly representable in double and float. | |||
| * Better to always use implementation from MUSL. | |||
| * | |||
| * Note: the function names are different to avoid confusion with symbols from the system libm. | |||
There was a problem hiding this comment.
The removal of this note looks strange.
alexey-milovidov
added
the
can be tested
alexey-milovidov
approved these changes
Feb 9, 2023
robot-piglet
pushed a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Remove excessive license notices from preciseExp10.cpp
Documentation entry for user-facing changes
Motivation
preciseExp10.cpp contains the whole COPYRIGHT text from musl-libc, which contains licenses for third-party code used in musl-libc.
preciseExp10.cpp initially uses code only from /src/math/exp10.c, which does not contain any additional license notices and therefore is distributed under standard MIT-clause.
The presence of excessive license notices in the file makes it difficult for our license-analyzer tool to properly mark up the licenses for ClickHouse source code in our codebase.