Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow vertical merges from compact to wide parts" #46236

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Feb 9, 2023

Reverts #45681

See #45681 (comment).

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 9, 2023
@CurtizJ CurtizJ merged commit 27bc317 into master Feb 10, 2023
@CurtizJ CurtizJ deleted the revert-45681-compact-parts-vertical-merge branch February 10, 2023 13:31
CurtizJ added a commit to CurtizJ/ClickHouse that referenced this pull request Feb 10, 2023
…681-compact-parts-vertical-merge"

This reverts commit 27bc317, reversing
changes made to ccf7b6f.
azat added a commit to azat/ClickHouse that referenced this pull request Feb 14, 2023
* upstream/master:
  Slightly improve error message for required Yasm assembler
  Update docs/en/operations/server-configuration-parameters/settings.md
  Instrumentation of callbacks for distributed queries
  Add an option for watchdog to restart the child process
  Fixed build
  Remove mutex from replicas_status
  [RFC] Revert ClickHouse#39737
  Update MergeTreeData.cpp
  Revert "Beter diagnostics from http in clickhouse-test"
  Fix macOs compilation due to sprintf
  Min Function Doc Fix
  Remove noisy logging
  Update RabbitMQProducer.cpp
  Simplify ATTACH MergeTree table FROM S3 in tests
  Fix style
  Try prevent flaky test
  Update test 00965_shard_unresolvable_addresses
  Fix build
  suppressing test inaccuracy
  more review fixes
  More reliable
  Add logging
  Update clickhouse-test
  add setting to disable vertical merges from compact parts
  Remove logging because of test 00002_log_and_exception_messages_formatting
  Try to make 02346_full_text_search less flaky
  Update clickhouse-test
  Update zstd to 1.5.4
  fix data race between check table query and background part checker thread
  Revert "Merge pull request ClickHouse#46236 from ClickHouse/revert-45681-compact-parts-vertical-merge"
  docs for logger stream_compression
  fix
  Fix FreeBSD build
  Update src/Storages/MergeTree/MergeTreeData.cpp
  Update src/Storages/MergeTree/MergeTreeData.cpp
  Update README.md
  Add upcoming Events
  ASTFunction: avoid rewriting tuple function as literal when not safe
  Fix possible out of bounds error while reading LowCardinality(Nullable) in Arrow format
  Fix clang-tidy
  Fix build
  Update run.sh
  More spelling fixes
  Review comments fix
  Update run.sh
  Fix duplicate includes in poco
  Fix spelling
  Update src/Storages/MergeTree/MergeTreeData.h
  rename API
  rename API
  Early return
  fix build error
  add API to MergeTreeData
  Add a test
  review fixes
  Update Curl to 7.87.0
  Reject DoS-prone hyperscan regexes
  Revert "Allow vertical merges from compact to wide parts"
  increase a time gap between insert and ttl move
  fix build error
  beauty
  Fix tests
  Fix write buffer destruction order for vertical merge.
  Fix ARM and PPC builds
  Update preciseExp10.cpp
  remove useless code
  add passes for rewriting arrayexists
  Automatic style fix
  Prefer explicitly defined creds for S3
  Implement ClickHouse#16733
  Fix something
  fix bugs
  Add a test for ClickHouse#30421
  Make it better
  add perf test
  Return note about function name in preciseExp10.h
  add visitor files
  rewrite array exists to has
  beauty
  reformat
  fix style
  fix bug
  fix bug
  Add setting check_referential_table_dependencies to check referential dependencies on DROP TABLE.
  Resubmit prefetches
  More warning exclusions in poco odbc
  fix style
  add test
  fix style
  Fix FreeBSD build
  Fix warnings in poco odbc
  fix style
  fix style
  fix style
  fix style
  fix style
  fix style
  fix pointer bug
  delete extra API and use dynamic_cast to compute
  Remove excessive license notices from preciseExp10.cpp
  add parts, active_parts total_marks to system.tables
  Fix whitespaces
  Add docs
  Fix warnings in poco json
  Fix warnings in poco xml
  Fix warnings in poco netssl_openssl
  Fix warnings in poco mongodb
  Fix warnings in poco utils
  Fix warnings in poco data
  Fix warnings in poco net
  Fix warnings in poco crypto
  Fix warnings in poco redis
  Fix warnings in poco foundation
  More fine-granular warning relaxation
  Add in code doc to sipHash128Reference
  Fix style
  Add a test
  Fix strange trash
  Remove bits of trash
  Add a test
  Allow accurate comparison of Big Int with other integers
  tests: add tests for sipHash128Reference{,Keyed}
  docs: functions: hash: add doc for sipHash126Reference{,Keyed}
  docs: functions: hash: fix wrong doc
  docs: functions: hash: add warning about sipHash128{,Keyed}
  Functions: Hashing: add sipHash128Reference{,Keyed}
  Common: SipHash: add original 128-bit output implementation
  Fix endian issue in CityHash for s390x
  Cleanup
  Fix integration test
  Cleanup
  Fix integration test
  Fix build
  Forbid wrong create view syntax
  Use new label from the event instead of all PR labels
  Improve readability by "elif"=>"if"
  Add early exit on freshly opened PR to not process labels
  Adding custom field continued
  Revert changes with complex SettingsChanges
  Add field CustomType
  Fix test after incorrect merge with master
  Properly detect changes in Rust code and recompile Rust libraries
  fix typos
  fix
  integrate IO scheduler with buffers
  DELETE + WHERE in TTL
  Update tests
  Add tags to test
  Support FixedSizeBinary type in Parquet/Arrow
  Update test
  Resolve some review comments
  Fix build
  Commit forgotten files
  Get rid of ASTPtr in settings changes
  Revert "Revert "Better code around SettingsChanges""
  Revert "Not better"
  Not better
  Revert "Better code around SettingsChanges"
  CLICKHOUSE-2375 Add interserver DNS retries
  Fix test
  Fix previous commit changes
  Fix
  Fix after merge
  Fix style check
  Better code around SettingsChanges
  Add local disk path restriction
  style
  Attempt to fix 'Local: No offset stored message' from Kafka
  Fix integration test
  Update 02454_create_table_with_custom_disk.sql
  Try fix test
  Fix test
  Avoid incorrect warning during update of DiskSelector disks
  Allow custom disk configuration
  Support single disk instead of storage policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants