Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zstd to 1.5.4 #46280

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Update zstd to 1.5.4 #46280

merged 1 commit into from
Feb 11, 2023

Conversation

Algunenano
Copy link
Member

@Algunenano Algunenano commented Feb 10, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Update zstd to v1.5.4. It has some minor improvements in performance and compression ratio. If you run replicas with different versions of ClickHouse you may see reasonable error messages Data after merge/mutation is not byte-identical to data on another replicas. with explanation. These messages are Ok and you should not worry.

Documentation entry for user-facing changes

Not needed

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

ZSTD release

I don't see any perf changes locally when using the ./src/IO/examples/zstd_buffers file, but let's see the perf results. I'm tagging this as a perf improvement to get perf tests in both x86 and ARM64, but it could be tagged as an Improvement instead.

Closes #43258

@robot-clickhouse robot-clickhouse added pr-performance Pull request with some performance improvements submodule changed At least one submodule changed in this PR. labels Feb 10, 2023
@evillique evillique self-assigned this Feb 10, 2023
@evillique
Copy link
Member

Test failures are not related

@evillique evillique merged commit 01d904d into ClickHouse:master Feb 11, 2023
@azat
Copy link
Collaborator

azat commented Feb 11, 2023

If you run replicas with different versions of ClickHouse you may see reasonable error messages Data after merge/mutation is not byte-identical to data on another replicas. with explanation

Hm, maybe it worth use backward incompatible changelog entry, and write there that there is nothing to worry about?
Since this error is pretty major and curious users may be concerned (if they do not follow clickhouse development).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update zstd 1.5.2 -> 1.5.3
5 participants