Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Extending S3-related functions/classes became a bit hard with everything in a huge
S3Common.cpp
file.I split the logic from there into different files (most of them are credentials related).
Also, I noticed that we didn't modify the logic for parsing args for S3 storage, just for the table functions. I extracted the logic for argument parsing so we don't make the same mistake again.
Documentation entry for user-facing changes