Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common logic for S3 #46339

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Extract common logic for S3 #46339

merged 3 commits into from
Feb 14, 2023

Conversation

antonio2368
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Extending S3-related functions/classes became a bit hard with everything in a huge S3Common.cpp file.
I split the logic from there into different files (most of them are credentials related).
Also, I noticed that we didn't modify the logic for parsing args for S3 storage, just for the table functions. I extracted the logic for argument parsing so we don't make the same mistake again.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 13, 2023
@kssenii kssenii self-assigned this Feb 13, 2023
src/Storages/StorageS3.cpp Outdated Show resolved Hide resolved
@antonio2368 antonio2368 force-pushed the refactor-s3 branch 2 times, most recently from 2721b93 to 8088232 Compare February 13, 2023 15:11
@antonio2368 antonio2368 merged commit 15df1fc into master Feb 14, 2023
@antonio2368 antonio2368 deleted the refactor-s3 branch February 14, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants