Do not continue perf tests in case of exception in create_query/fill_query #46362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query Previously due to using of threading.Thread, exception had been ignored, and perf test simply continues, yes it will show some errors, but it also may show that the test became faster, while it is because the underlying table was empty. Replace threading.Thread with a SafeThread (inline implementation) that simply rethrow exception in join. Here is an example of such report [1], look at the ip_trie test. [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/2101b66570cbb9eb9a492afa8ab82d562c34336b/performance_comparison_[3/4]/report.html Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
robot-ch-test-poll3
added
the
pr-not-for-changelog
vdimir
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously due to using of threading.Thread, exception had been ignored, and perf test simply continues, yes it will show some errors, but it also may show that the test became faster, while it is because the underlying table was empty.
Replace threading.Thread with a SafeThread (inline implementation) that simply rethrow exception in join.
Here is an example of such report 1, look at the ip_trie test.
Changelog category (leave one):