Minor fix in files locating for Bugfix validate check #46368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll3
added
the
pr-not-for-changelog
serxa
reviewed
Feb 13, 2023
tests/ci/functional_test_check.py
Outdated
| fname = fpath.split("/")[3] | ||
| fname_without_ext = os.path.splitext(fname)[0] | ||
| # Add '.' to the end of the test name not to run all tests with given prefix. | ||
| # We do not want to specify exact file extension not to complicate matching and look only for .reference |
There was a problem hiding this comment.
What if the .reference file is not changed, but the query does?
There was a problem hiding this comment.
Indeed, thanks. I returned logic back, just with the change tests/queries/0_stateless/0 to tests/queries/0_stateless/[0-9]{5}
vdimir
force-pushed
the
vdimir/bugfix-validate-fix
branch
from
1c92eed
to
19b5d21
Compare
serxa
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes