Backport #46367 to 23.1: Do not build libclickhouse-keeper-lib.a for standalone keeper #46477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…standalone keeper
robot-ch-test-poll1
added
the
pr-backport
robot-clickhouse
force-pushed
the
backport/23.1/46367
branch
from
32c7a31
to
5ebf68c
Compare
|
@alexey-milovidov why? |
|
Insignificant change, not worth looking at. |
|
It reduces the build time significantly by removing A LOT of THINLTO linking. And even one less unnecessary build. It really worth to merge back everywhere |
|
Integration and stree tests are the same as in the PR, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull-request #46367
Cherry-pick pull-request #46476
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.