Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing Const(LowCardinality) in arrayMap #46569

Merged
merged 9 commits into from
Feb 21, 2023
Merged

Fix processing Const(LowCardinality) in arrayMap #46569

merged 9 commits into from
Feb 21, 2023

Conversation

alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Feb 19, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix an invalid processing of constant LowCardinality argument in function arrayMap. This bug could lead to a segfault in release, and logical error Bad cast in debug build.

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 19, 2023
@Avogar Avogar self-assigned this Feb 20, 2023
@Avogar
Copy link
Member

Avogar commented Feb 20, 2023

I found the bug, I will add a fix to this PR

@Avogar Avogar changed the title Add a bug Fix processing Const(LowCardinality) in arrayMap Feb 20, 2023
@KochetovNicolai KochetovNicolai self-assigned this Feb 20, 2023
@Avogar Avogar merged commit 36870f0 into master Feb 21, 2023
@Avogar Avogar deleted the add-bug branch February 21, 2023 12:11
@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Feb 21, 2023
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 21, 2023
robot-ch-test-poll3 added a commit that referenced this pull request Feb 22, 2023
Backport #46569 to 22.8: Fix processing Const(LowCardinality) in arrayMap
Avogar added a commit that referenced this pull request Feb 22, 2023
Backport #46569 to 23.1: Fix processing Const(LowCardinality) in arrayMap
Avogar added a commit that referenced this pull request Feb 22, 2023
Backport #46569 to 22.12: Fix processing Const(LowCardinality) in arrayMap
Avogar added a commit that referenced this pull request Feb 22, 2023
Backport #46569 to 22.11: Fix processing Const(LowCardinality) in arrayMap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants