Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poco: Remove some dead code #46768

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Poco: Remove some dead code #46768

merged 1 commit into from
Feb 23, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Feb 23, 2023

Cf. this feedback

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 23, 2023
@nickitat nickitat self-assigned this Feb 23, 2023
@@ -212,25 +212,6 @@
#endif


#if defined(__clang__)
# define POCO_COMPILER_CLANG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... not needed because the only usage was in base/poco/Foundation/include/Poco/Alignment.h

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... true

@rschu1ze rschu1ze merged commit c6f7bbe into master Feb 23, 2023
@rschu1ze rschu1ze deleted the rs/poco-cleanup branch February 23, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants