Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix combined PREWHERE column accumulated from multiple steps #46785

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

davenger
Copy link
Member

@davenger davenger commented Feb 23, 2023

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Combined PREWHERE column accumulated from multiple PREWHERE in some cases didn't contain 0's from previous steps.
The fix is to apply final filter if we know that it wasn't applied from more than 1 last step.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 23, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Feb 23, 2023
@nickitat nickitat self-assigned this Feb 23, 2023
@davenger davenger merged commit b43b98f into master Feb 24, 2023
@davenger davenger deleted the fix_combined_prewhere_column branch February 24, 2023 13:00
robot-clickhouse added a commit that referenced this pull request Feb 24, 2023
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 24, 2023
davenger added a commit that referenced this pull request Feb 24, 2023
Backport #46785 to 23.2: Fix combined PREWHERE column accumulated from multiple steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default v23.2-must-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants