Remove ZSTD version from CMake output #46796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- produced wrong output: > ZSTD VERSION 1.5.0 (see any recent local or CI build log), whereas the current version is 1.5.4 - that could be fixed, on the other hand other contrib's also don't print their version (it is given implicitly by ClickHouse's source Git hash), the parsing regex is fragile and it hasn't changed since 2016 so it was probably broken for a long time already - therefore remove it
robot-clickhouse
added
pr-not-for-changelog
alexey-milovidov
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produced wrong output:
(see any recent local or CI build log), the current version is 1.5.4
That could be fixed, on the other hand other contrib's also don't print their version (it is given implicitly by ClickHouse's source Git hash), the parsing regex is fragile and it hasn't changed since 2016 so it was probably broken for a long time already and nobody cared
--> remove it
Changelog category (leave one):