Small optimization of LIKE patterns with > 1 trailing % #46869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-not-for-changelog
rschu1ze
force-pushed
the
rs/like-with-trailing-percentage
branch
3 times, most recently
from
f313505
to
22ec5c7
Compare
Previously, LIKE pattern '%%%ab' became '.*.*ab'. Now, it becomes 'ab' which is a bit faster (perhaps). + minor code cleanup + a minor doc update
rschu1ze
force-pushed
the
rs/like-with-trailing-percentage
branch
from
22ec5c7
to
cf062f0
Compare
This was referenced Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, LIKE pattern
%%%abbecame re2 regexp.*.*ab. Now, it becomesabwhich should be a bit faster.Courtesy to @XenoAmess's #46695. Pushed this optimization separately because LIKEly (pun intended) the other PR is no longer needed.
+ minor code cleanup
+ a minor doc update
Also see #46592
Changelog category (leave one):