Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test test_async_backups_to_same_destination. #46888

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Fix test test_async_backups_to_same_destination. #46888

merged 1 commit into from
Feb 26, 2023

Conversation

vitlibar
Copy link
Member

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 25, 2023
@vitlibar vitlibar force-pushed the fix-test_async_backups_to_same_destination branch from 77b4be9 to 2d38c89 Compare February 25, 2023 22:38
@alexey-milovidov alexey-milovidov self-assigned this Feb 26, 2023
@alexey-milovidov
Copy link
Member

Any explanation?

@vitlibar
Copy link
Member Author

vitlibar commented Feb 26, 2023 •
edited

Any explanation?

I need to convert a TSV result from ClickHouse to a list of lines in Python.
But it appears Python calculates ''.split("\n") as [''] (a list with one empty string) somehow, not an empty list. Which is not what I want. splitlines() suits this case better.

@alexey-milovidov alexey-milovidov merged commit 9ac48dd into ClickHouse:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitlibar @alexey-milovidov @robot-ch-test-poll