Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - WITH FILL would produce abort when FillingTransform processing empty block #46897

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

yakov-olkhovskiy
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix WITH FILL abort when FillingTransform processing empty block

Query example:

SELECT
    2 AS x,
    arrayJoin([NULL, NULL, NULL])
GROUP BY
    GROUPING SETS (
        (0),
        ([NULL, NULL, NULL]))
ORDER BY x ASC WITH FILL FROM 1 TO 10

result:

clickhouse: /home/ubuntu/ClickHouse-fill/src/Columns/ColumnVector.h:265: virtual DB::Field DB::ColumnVector<char8_t>::operator[](size_t) const
[T = char8_t]: Assertion `n < data.size()' failed.
Aborted (core dumped)

reported by fuzzer:
https://s3.amazonaws.com/clickhouse-test-reports/46731/5af6ac534e1ae4b6ea2384ed9b1cd723e9e22de8/fuzzer_astfuzzermsan/report.html

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 25, 2023
@alexey-milovidov
Copy link
Member

Please also copy-paste the query to a new test.

@alexey-milovidov alexey-milovidov self-assigned this Feb 26, 2023
@alexey-milovidov alexey-milovidov merged commit df5c7c9 into master Feb 26, 2023
@alexey-milovidov alexey-milovidov deleted the fix-fill-empty-block branch February 26, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants