Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query plan: update sort description #47319

Merged
merged 15 commits into from
Apr 3, 2023

Conversation

devcrafter
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@devcrafter devcrafter marked this pull request as draft March 7, 2023 22:16
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 7, 2023
@devcrafter devcrafter added the force tests The label does nothing, NOOP, None, nil label Mar 8, 2023
@devcrafter devcrafter removed the force tests The label does nothing, NOOP, None, nil label Mar 13, 2023
@devcrafter devcrafter marked this pull request as ready for review March 15, 2023 19:16
@KochetovNicolai KochetovNicolai self-assigned this Mar 15, 2023
return;

FindOriginalNodeForOutputName original_node_finder(actions_dag);
const auto & input_sort_description = getInputStreams().front().sort_description;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of copy-paste, can we move it into FindOriginalNodeForOutputName

@KochetovNicolai KochetovNicolai merged commit d4b91b7 into master Apr 3, 2023
@KochetovNicolai KochetovNicolai deleted the query-plan-update-sort-description branch April 3, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants