Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Cloud Storage S3 compatible table function #47815

Merged
merged 22 commits into from
May 5, 2023

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented Mar 21, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add Google Cloud Storage S3 compatible table function gcs. Like the oss and cosn functions, it is just an alias over the s3 table function, and it does not bring any new features.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-feature Pull request with new product feature label Mar 21, 2023
@ucasfl ucasfl added the can be tested Allows running workflows for external contributors label Mar 21, 2023
@jkaflik jkaflik marked this pull request as ready for review March 21, 2023 12:47
@nikitamikhaylov
Copy link
Member

@jkaflik @alexey-milovidov There is a build error, rebasing to a recent master won't help in any way.

Apr 17 06:34:01 In file included from /build/src/TableFunctions/TableFunctionS3Cluster.cpp:14:
Apr 17 06:34:01 /build/src/TableFunctions/TableFunctionS3.h:96:33: error: unknown class name 'TableFunctionS3'; did you mean 'DB::TableFunctionS3'?
Apr 17 06:34:01 class TableFunctionGCS : public TableFunctionS3
Apr 17 06:34:01                                 ^~~~~~~~~~~~~~~
Apr 17 06:34:01                                 DB::TableFunctionS3
Apr 17 06:34:01 /build/src/TableFunctions/TableFunctionS3.h:18:7: note: 'DB::TableFunctionS3' declared here
Apr 17 06:34:01 class TableFunctionS3 : public ITableFunction
Apr 17 06:34:01       ^
Apr 17 06:34:01 /build/src/TableFunctions/TableFunctionS3.h:116:1: error: extraneous closing brace ('}')
Apr 17 06:34:01 }
Apr 17 06:34:01 ^
Apr 17 06:34:01 2 errors generated.
Apr 17 06:34:01 [11311/11344] Building CXX object programs/local/CMakeFiles/clickhouse-local-lib.dir/LocalServer.cpp.o
Apr 17 06:34:01 [11312/11344] Building CXX object programs/copier/CMakeFiles/clickhouse-copier-lib.dir/TaskCluster.cpp.o
Apr 17 06:34:02 [11313/11344] Building CXX object src/TableFunctions/CMakeFiles/clickhouse_table_functions.dir/TableFunctionS3.cpp.o

@jkaflik
Copy link
Contributor Author

jkaflik commented Apr 18, 2023

@nikitamikhaylov thanks. I will have a look. (never been on my priority list)

@@ -93,4 +93,26 @@ class TableFunctionOSS : public TableFunctionS3

}

class TableFunctionGCS : public TableFunctionS3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've put it outside of the namespace.

@alexey-milovidov alexey-milovidov self-assigned this Apr 27, 2023
@alexey-milovidov
Copy link
Member

@jkaflik I've edited the changelog to more clearly describe the innovation.

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Apr 27, 2023
@alexey-milovidov
Copy link
Member

@jkaflik it is not documented in the code base.

@robot-clickhouse
Copy link
Member

robot-clickhouse commented May 4, 2023

This is an automated comment for commit 8a6084a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🔴 failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🔴 failure
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@robot-clickhouse
Copy link
Member

This is an automated comment for commit 0672d75 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@jkaflik
Copy link
Contributor Author

jkaflik commented May 5, 2023

@alexey-milovidov I added inline code documentation. I did it for S3, also. Not familiar with COS and OSS. It can be added in the future.

@alexey-milovidov alexey-milovidov merged commit 965956a into ClickHouse:master May 5, 2023
256 of 263 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants