-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Cloud Storage S3 compatible table function #47815
Add Google Cloud Storage S3 compatible table function #47815
Conversation
…e into add-gcs-table-function
@jkaflik @alexey-milovidov There is a build error, rebasing to a recent master won't help in any way.
|
@nikitamikhaylov thanks. I will have a look. (never been on my priority list) |
src/TableFunctions/TableFunctionS3.h
Outdated
@@ -93,4 +93,26 @@ class TableFunctionOSS : public TableFunctionS3 | |||
|
|||
} | |||
|
|||
class TableFunctionGCS : public TableFunctionS3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've put it outside of the namespace.
@jkaflik I've edited the changelog to more clearly describe the innovation. |
@jkaflik it is not documented in the code base. |
This is an automated comment for commit 8a6084a with description of existing statuses. It's updated for the latest CI running
|
This is an automated comment for commit 0672d75 with description of existing statuses. It's updated for the latest CI running
|
…e into add-gcs-table-function
@alexey-milovidov I added inline code documentation. I did it for S3, also. Not familiar with COS and OSS. It can be added in the future. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add Google Cloud Storage S3 compatible table function
gcs
. Like theoss
andcosn
functions, it is just an alias over thes3
table function, and it does not bring any new features.Documentation entry for user-facing changes