Optimize compilation #47984
Merged
Optimize compilation #47984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll3
added
the
pr-build
nickitat
reviewed
Mar 26, 2023
|
|
||
| } | ||
|
|
||
| using Int128 = wide::integer<128, signed>; |
There was a problem hiding this comment.
maybe replace with #include <Core/Types_fwd.h>?
There was a problem hiding this comment.
Unfortunately, I can't move concept is_decimal declaration there so I had to create base/Decimal_fwd.h.
There was a problem hiding this comment.
I meant lines 5-16 in this file repeat the same declarations that exist in Types_fwd.h
novikd
force-pushed
the
optimize-compilation
branch
from
be4b591
to
5cc9b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Reduce the number of dependencies in the header files to speed up the build.