Only check MV on ALTER when necessary #48062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
ALTER TABLE
queries.Documentation entry for user-facing changes
Since forever (all supported releases), when CH wants to do an
ALTER
over a table it callsgetDependentViewsByColumn
to check the columns used by dependencies (materialized views, etc). My guess is that in order to avoid calling this multiple times in an execution it was moved outside of the loop, but this means that unrelated alters might check dependencies which can be really expensive.For example, if you modify a table TTL and that table has 100 MV pending from it you will have 100 checks which are unnecessary.