Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify backup coordination for file infos #48095

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented Mar 28, 2023

Changelog category:

  • Not for changelog

Decrease the number of zookeeper nodes created and read during a backup process.
Build all file infos before writing anything to backup (that will allow to show progress for on cluster backups properly).
Remove some obsolete code.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 28, 2023
@vitlibar vitlibar force-pushed the simplify-backup-coordination-for-file-infos branch from 68ac7b3 to daa08bb Compare March 28, 2023 10:41
@nikitamikhaylov nikitamikhaylov self-assigned this Mar 28, 2023
@vitlibar vitlibar force-pushed the simplify-backup-coordination-for-file-infos branch 2 times, most recently from ab527bb to 9ca15b9 Compare March 28, 2023 22:15
@vitlibar vitlibar force-pushed the simplify-backup-coordination-for-file-infos branch from 9ca15b9 to 273279e Compare March 28, 2023 22:26
@nikitamikhaylov
Copy link
Member

Stress tests - #47159

@nikitamikhaylov nikitamikhaylov merged commit 481a7a7 into ClickHouse:master Mar 29, 2023
@vitlibar vitlibar deleted the simplify-backup-coordination-for-file-infos branch April 3, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants