parseDateTime[InJodaSyntax](): Require format argument #48222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function parseDateTime[InJodaSyntax]() previously accepted an (undocumented) default format string. The problem was that 1. there is no "natural" default format 2. MySQL str_to_date() (= the motivation for parseDateTime[InJodaSyntax]()) also provides no default format. --> get rid of the default format
robot-ch-test-poll3
added
the
pr-not-for-changelog
This comment was marked as outdated.
This comment was marked as outdated.
davenger
reviewed
Mar 31, 2023
davenger
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function parseDateTime[InJodaSyntax]() previously accepted an (undocumented) default format string. The problem was that
--> get rid of the default format
@taiyang-li
Changelog category (leave one):