Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling examples without Hive #48269

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Conversation

azat
Copy link
Collaborator

@azat azat commented Mar 31, 2023

Skip compiling comma_separated_streams since it requires Hive.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Skip compiling comma_separated_streams since it requires Hive.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 31, 2023
@rschu1ze rschu1ze self-assigned this Mar 31, 2023
@rschu1ze
Copy link
Member

Verified locally that there is a problem when hive is off and that the PR resolves it. No general objections.

But: It would perhaps a bit more elegant to keep the CMakeLists as is, and instead

  • #include "config.h" into comma_separated_streams.cpp" and
  • wrap all contained contained code in #if USE_HIVE (see Processors/Formats/Impl/HiveTextRowInputFormat.h which is the source of the trouble).

@azat
Copy link
Collaborator Author

azat commented Mar 31, 2023

#include "config.h" into comma_separated_streams.cpp" and

Yes, I thought about this, but this example comma_separated_streams.cpp does not work without Hive anyway, and even main function will be empty, so decided to exclude from cmake instead

@rschu1ze rschu1ze merged commit a54f477 into ClickHouse:master Mar 31, 2023
4 of 5 checks passed
@azat azat deleted the build/hive-fix branch March 31, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants