Add strict mode for KeeperMap #48293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll3
added
the
pr-improvement
vdimir
approved these changes
Apr 3, 2023
| @@ -105,6 +107,7 @@ TRUNCATE TABLE keeper_map_table; | |||
| ### Updates | |||
|
|
|||
| Values can be updated using `ALTER TABLE` query. Primary key cannot be updated. | |||
| If setting `keeper_map_strict_mode` is set to `true`, fetching and updating data will succeed only if it's executed atomically. | |||
There was a problem hiding this comment.
To be sure: we execute ALTER in one mutate call and update actual values in sink->finalize<true> call. That's why updating one chunk of data and getting an exception later is impossible, is it?
There was a problem hiding this comment.
yes, we actualy send requests only on finalize.
Until then we fetch and modify data locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add new setting
keeper_map_strict_modewhich enforces extra guarantees on operations made on top ofKeeperMaptables.Documentation entry for user-facing changes