Fix: copy forgotten show_secrets in FormatSettings semi-copy-ctor #48297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-not-for-changelog
vitlibar
added
the
can be tested
vitlibar
approved these changes
Mar 31, 2023
|
@vitlibar could you help me understand what's the CI problem? I see that it's |
|
The test failure 00002_log_and_exception_messages_formatting doesn't seem related to this PR's changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during working on #45649.
Not a bug, but rather an inconsistency, as there seems to be no usage of that semi-copy-ctor involving secrets.
This is the only usage:
ClickHouse/src/Parsers/Access/ASTCreateRowPolicyQuery.cpp
Line 63 in 854e1e9
I grepped by case-aware
FormatSettings.*(\{|\().*,.*(\}|\)). Then commented out the semi-copy-ctor and this usage and was able to compile correctly.Changelog category (leave one):