Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't replicate mutations for KeeperMap tables #48354

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Don't replicate mutations for KeeperMap tables #48354

merged 6 commits into from
Apr 4, 2023

Conversation

antonio2368
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Don't replicate mutations for KeeperMap because it's unnecessary.

cc @tavplubix

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

tavplubix
tavplubix approved these changes Apr 3, 2023
View reviewed changes
src/Interpreters/InterpreterAlterQuery.cpp Outdated Show resolved Hide resolved
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-improvement Pull request with some product improvements label Apr 3, 2023
@antonio2368 antonio2368 merged commit 7fe0973 into master Apr 4, 2023
5 of 6 checks passed
@antonio2368 antonio2368 deleted the dont-replicate-mutations-keepermap branch April 4, 2023 07:56
@antonio2368 antonio2368 mentioned this pull request Apr 5, 2023
Merged
1 task
@tavplubix tavplubix mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees
No one assigned
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antonio2368 @tavplubix @robot-clickhouse-ci-1