Batch fix for projections analysis with analyzer. #48357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
KochetovNicolai
commented
Apr 3, 2023
KochetovNicolai
commented
Apr 3, 2023
novikd
reviewed
Apr 5, 2023
| LOG_TRACE(&Poco::Logger::get("optimizeUseProjections"), "Cannot match agg func {} vs {} by state {} vs {}", | ||
| aggregate.column_name, candidate.column_name, | ||
| candidate.function->getStateType()->getName(), aggregate.function->getStateType()->getName()); | ||
| // LOG_TRACE(&Poco::Logger::get("optimizeUseProjections"), "Cannot match agg func {} vs {} by state {} vs {}", |
| } | ||
|
|
||
| size_t num_args = aggregate.argument_names.size(); | ||
|
|
||
| DataTypes argumen_types; |
There was a problem hiding this comment.
Suggested change
| DataTypes argumen_types; | |
| DataTypes argument_types; |
robot-clickhouse
added a commit
that referenced
this pull request
Apr 6, 2023
robot-ch-test-poll2
added
the
pr-backports-created
KochetovNicolai
added a commit
that referenced
this pull request
Apr 12, 2023
Backport #48357 to 23.3: Batch fix for projections analysis with analyzer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):