Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test "02494_query_cache_drop.sql" #48358

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix test "02494_query_cache_drop.sql" #48358

merged 1 commit into from
Apr 3, 2023

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Apr 3, 2023

Reverts #45912

@CurtizJ
Copy link
Member Author

CurtizJ commented Apr 3, 2023

Test 02494_query_cache_drop_cache is broken in master.

@CurtizJ CurtizJ mentioned this pull request Apr 3, 2023
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 3, 2023
@rschu1ze
Copy link
Member

rschu1ze commented Apr 3, 2023

Thanks, I'll check ... (as far as I remember, the test was locally green when I merged)

@rschu1ze
Copy link
Member

rschu1ze commented Apr 3, 2023 •
edited

Can reproduce the issue locally. It happens if the new test "02494_query_cache_squash_partial_results" (introduced with #45912) runs immediately prior to "02494_query_cache_drop_cache", apparently I did not check this combination locally :/

If it is okay, I'd push a commit in this PR which fixes this instead of rolling everything back.

@rschu1ze rschu1ze force-pushed the revert-45912-qc-compression branch from f1516aa to e2035b4 Compare April 3, 2023 17:44
@rschu1ze
Fix 02494_query_cache_drop.sql
fea5fae 
Failing with high rate in master after #45912 was merged
@rschu1ze rschu1ze force-pushed the revert-45912-qc-compression branch from e2035b4 to fea5fae Compare April 3, 2023 17:45
@rschu1ze rschu1ze changed the title Revert "Query cache: Enable compression of cache entries" Fix test "02494_query_cache_drop.sql" Apr 3, 2023
@rschu1ze
Copy link
Member

rschu1ze commented Apr 3, 2023

I am technically not the author of this PR which implies that I can approve and merge it 😎 (fast test + the functional tests which ran are green)

@rschu1ze rschu1ze merged commit 055c754 into master Apr 3, 2023
99 of 138 checks passed
@rschu1ze rschu1ze deleted the revert-45912-qc-compression branch April 3, 2023 20:31
@CheSema CheSema mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees
No one assigned
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CurtizJ @rschu1ze @robot-ch-test-poll3