-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find big allocations without memory limits checks #48401
Conversation
|
||
MemoryTrackerBlockerInThread blocker; | ||
LOG_TRACE(&Poco::Logger::get("MemoryTracker"), "Too big allocation ({} bytes) without checking memory limits, " | ||
"it may lead to OOM. Stack trace: {}", size, StackTrace().toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting idea! Maybe it also worth to add a check to {stateless/stress}/run.sh
for this pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix known issues first:
rg -Faz "Too big allocation" clickhouse-server.log.zst | wc
1484 46004 462441
Integration tests (asan) [4/6] - #45435 |
Changelog category (leave one):
About big allocations and OOMs: #48178 (comment)
Also it fixes
00002_log_and_exception_messages_formatting
: https://s3.amazonaws.com/clickhouse-test-reports/0/d0ba1e76bfdef462ae5fd7b652105b4abf780251/stateless_tests__release_.html(the test has found non-informative exception messages added in #43858 (comment), but it was impossible to understand from the test output, let's improve it)
Fixes #48441