Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_keeper_snapshots #48417

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

antonio2368
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)
2023-04-04 22:35:38 [ 6903 ] DEBUG : Sending request(xid=None): Connect(protocol_version=0, last_zxid_seen=0, time_out=30000, session_id=0, passwd=b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00', read_only=None) (connection.py:312, _submit)
2023-04-04 22:35:38 [ 6903 ] INFO : Zookeeper connection established, state: CONNECTED (client.py:532, _session_callback)
2023-04-04 22:35:38 [ 6903 ] WARNING : Connection dropped: socket connection broken (connection.py:622, _connect_attempt)

It connected, but ZK clients don't support rejection in handshake we send if server is not active so Keeper just drops the connection while ZK thinks everything is okay.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 5, 2023
@tavplubix tavplubix self-assigned this Apr 5, 2023
@tavplubix
Copy link
Member

Integration tests (asan) [1/6] - #43084
Integration tests flaky check (asan) - OK

@tavplubix tavplubix merged commit d7879c1 into master Apr 5, 2023
106 of 139 checks passed
@tavplubix tavplubix deleted the fix-test-keeper-snapshots branch April 5, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants