Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lost_part_count column to system.replicas #48526

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Add lost_part_count column to system.replicas #48526

merged 7 commits into from
Apr 11, 2023

Conversation

serxa
Copy link
Member

@serxa serxa commented Apr 6, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added a lost_part_count column to the system.replicas table. The column value shows the total number of lost parts in the corresponding table. Value is stored in zookeeper and can be used instead of not persistent ReplicatedDataLoss profile event for monitoring.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Fixes #47946

@robot-clickhouse robot-clickhouse added the pr-feature Pull request with new product feature label Apr 6, 2023
Copy link
Member

@tavplubix tavplubix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a test. You can simply modify 01165_lost_part_empty_partition or 02369_lost_part_intersecting_merges

src/Storages/StorageReplicatedMergeTree.cpp Outdated Show resolved Hide resolved
@tavplubix tavplubix self-assigned this Apr 7, 2023
serxa and others added 3 commits April 7, 2023 17:07
@serxa
Copy link
Member Author

serxa commented Apr 10, 2023

Stateless tests flaky check (asan) — fail: 6

01165_lost_part_empty_partition - timeouts (>60sec) - it is strange because normally it is done in few seconds
02221_system_zookeeper_unrestricted - timeouts - the same problem, normally it is fast

@serxa serxa merged commit ca6e253 into master Apr 11, 2023
144 checks passed
@serxa serxa deleted the lost-part-count branch April 11, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a column with the number of "lost forever" parts to system.replicas
3 participants