Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending nullptr to memcpy in copyStringInArena #48532

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

antonio2368
Copy link
Member

@antonio2368 antonio2368 commented Apr 7, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Avoid sending nullptr to memcpy in copyStringInArena.

Fix #48470

Problem is that ColumnArray for empty arrays creates StringRef(nullptr, 0)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@evillique evillique self-assigned this Apr 7, 2023
@evillique evillique merged commit 2fd2079 into master Apr 7, 2023
98 of 136 checks passed
@evillique evillique deleted the fix-topk-ubsan branch April 7, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitizer trap (ubsan) AggregateFunctionTopK
2 participants