Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one ThreadGroup while pushing to materialized views (and some refactoring for ThreadGroup) #48543

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Use one ThreadGroup while pushing to materialized views (and some refactoring for ThreadGroup) #48543

merged 3 commits into from
Apr 11, 2023

Conversation

azat
Copy link
Collaborator

@azat azat commented Apr 7, 2023 •
edited

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog:

Cc: @CheSema

azat added 3 commits April 7, 2023 15:31
@azat
Rename ThreadGroupStatus to ThreadGroup
5b2b20a 
There are methods like getThreadGroup() and ThreadGroupSwitcher class,
so seems that this is logical.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
Move ThreadGroupSwitcher to ThreadStatus.h (out from MergeTree code)
aacf2a0 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
Use one ThreadGroup while pushing to materialized views
44ae848 
Before this patch only the case when ThreadStatus (current_thread)
already has ThreadGroup works that way, after they will be identical in
this aspect.

But this should not affect anything, but it just make sense.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat mentioned this pull request Apr 7, 2023
Merged
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 7, 2023
@CheSema CheSema self-assigned this Apr 7, 2023
@azat
Copy link
Collaborator Author

azat commented Apr 7, 2023

Stateless tests (tsan) [3/5] — fail: 1, passed: 1057, skipped: 21

@CheSema CheSema merged commit 4dd86a4 into ClickHouse:master Apr 11, 2023
136 checks passed
@azat azat deleted the mv-uniq-thread-group branch April 11, 2023 09:51
This was referenced Apr 11, 2023
Merged
Merged
nickitat added a commit to nickitat/ClickHouse that referenced this pull request May 31, 2023
@nickitat
Revert "Merge pull request ClickHouse#48543 from azat/mv-uniq-thread-…
105d0b3 
…group"

This reverts commit 4dd86a4, reversing
changes made to 13c92ad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CheSema CheSema

Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azat @robot-clickhouse @CheSema