Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: compare Bits and sizeof(Arithmetic) * 8 #48569

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

awfeequdng
Copy link
Contributor

@awfeequdng awfeequdng commented Apr 9, 2023

Changelog category (leave one):

  • Not For Changelog

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

compare Bits and sizeof(Arithmetic):because Bits is bit count, but sizeof(Arithmetic) is byte count, so compare Bits and sizeof(Arithmetic) like this:
Bits < sizeof(Arithmetic) * 8
or Bits > sizeof(Arithmetic) * 8
or Bits == sizeof(Arithmetic) * 8

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2023

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Apr 9, 2023
@alexey-milovidov alexey-milovidov self-assigned this Apr 10, 2023
@alexey-milovidov alexey-milovidov merged commit a7db8d1 into ClickHouse:master Apr 10, 2023
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants