Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous includes of logger_userful.h from headers #48570

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

azat
Copy link
Collaborator

@azat azat commented Apr 9, 2023

To improve build time on changes, since logger_useful.h includes also CurrentThread.h and ThreadStatus.h

Basically do not include logger_useful.h in the headers if LOG_* is not used:

git grep Common/logger_useful.h -- src/**.h | cut -d: -f1 | sort -u | xargs -i sh -c "grep -q LOG_ {} || echo {}" | xargs -t sed -i '/logger_useful/d'

Plus some fixes on top of this.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 9, 2023
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@alexey-milovidov alexey-milovidov merged commit d259217 into ClickHouse:master Apr 11, 2023
136 checks passed
@azat azat deleted the build/logger_useful branch April 11, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants