-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
groupArray
returns cannot be nullable
#48593
groupArray
returns cannot be nullable
#48593
Conversation
e602e05
to
e56f5dd
Compare
d9b900e
to
572bc5b
Compare
change the result of SELECT groupArray(NULL)
┌─groupArray(NULL)─┐
│ [] │
└──────────────────┘
SELECT toTypeName(groupArray(NULL))
┌─toTypeName(groupArray(NULL))─┐
│ Array(Nullable(Nothing)) │
└──────────────────────────────┘
|
d54108a
to
255e84e
Compare
255e84e
to
f4d022b
Compare
f4d022b
to
3a5e0b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's pray we didn't break backward compatibility
This does break the binary format (updated test references shows that there are problems), so I'm suggesting to revert it for now - #49971 (yes one release already affected, but I don't see a way to fix this in a binary compatible way now, and I hope that not a lot people affected by this), and fix it without breaking compatibility (also I found more changes of the on disk format for aggregate functions over Nullable, that comes from #11593) Thoughts? |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed
Nested type Array(T) cannot be inside Nullable type
forgroupArray
function.closed #48462