Fix flakiness of test_store_cleanup in case of image rebuild #48610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log level will be substituted from "test" to "trace" in case of the tag is not "latest", the assumption behind this I guess is that it should not try to use "test" log level for older versions. But, it could have per-PR image in case of changes in the Dockerfile, so it is better to check for self.with_installed_binary, since actually any parameters except this will use new clickhouse binary anyway. CI: https://s3.amazonaws.com/clickhouse-test-reports/48596/a1272e8536265929255fdf5020836f057859e425/integration_tests__tsan__[1/6].html Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
robot-ch-test-poll1
added
the
pr-not-for-changelog
tavplubix
approved these changes
Apr 11, 2023
|
Stateless tests (tsan) [3/5] - #48534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log level will be substituted from "test" to "trace" in case of the tag is not "latest", the assumption behind this I guess is that it should not try to use "test" log level for older versions.
But, it could have per-PR image in case of changes in the Dockerfile, so it is better to check for self.with_installed_binary, since actually any parameters except this will use new clickhouse binary anyway.
CI: https://s3.amazonaws.com/clickhouse-test-reports/48596/a1272e8536265929255fdf5020836f057859e425/integration_tests__tsan__[1/6].html
Changelog category (leave one):