Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http temporary buffer integration with fs cache #48664

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Apr 11, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • HTTP temporary buffer support working with fs cache.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label Apr 11, 2023
@kssenii kssenii self-assigned this Apr 11, 2023
@vdimir vdimir force-pushed the vdimir/http_tmp_buffer_fs_cache branch from ba82aa5 to 177224d Compare April 12, 2023 09:11
@vdimir vdimir requested a review from kssenii April 13, 2023 09:20
src/Server/HTTPHandler.cpp Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.h Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.h Show resolved Hide resolved
src/Server/HTTPHandler.cpp Outdated Show resolved Hide resolved
@vdimir vdimir force-pushed the vdimir/http_tmp_buffer_fs_cache branch 2 times, most recently from 246c5d2 to 3c9a035 Compare April 19, 2023 13:48
@vdimir vdimir force-pushed the vdimir/http_tmp_buffer_fs_cache branch from 3c9a035 to 61635eb Compare April 19, 2023 14:44
@vdimir
Copy link
Member Author

vdimir commented Apr 19, 2023

Rerun CI to check integration tests broken by bad docker image

@vdimir
Copy link
Member Author

vdimir commented Apr 20, 2023

Stateless tests (release, wide parts enabled) — fail: 1, passed: 5249, skipped: 6 Details

02706_arrow_different_dictionaries - fixed in master

Integration tests (release) [3/4] — fail: 32, passed: 385, flaky: 0 Details

Can't connect to HDFS or preparations are not done yet 403 Client Error: Forbidden for url: http://172.16.14.2:50070/webhdfs/v1/somefilewithrandomname222?op=CREATE&overwrite=true (cluster.py:2355, wait_hdfs_to_start)

Upgrade check (debug) — OOM in dmesg Details

2023.04.19 23:03:05.001744 [ 1318 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 59.18 GiB, peak 58.51 GiB, free memory in arenas 187.36 MiB, will set to 59.25 GiB (RSS), difference: 62.37 MiB
2023.04.19 23:03:05.001774 [ 1318 ] {} <Debug> MemoryTracker: Current memory usage (total): 59.25 GiB.

@vdimir vdimir merged commit 99ac321 into master Apr 20, 2023
138 checks passed
@vdimir vdimir deleted the vdimir/http_tmp_buffer_fs_cache branch April 20, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants