Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix roundAge() #48673

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Docs: Fix roundAge() #48673

merged 3 commits into from
Apr 12, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Apr 11, 2023 •
edited

Fixes #48640

Changelog category (leave one):

  • Documentation (changelog entry is not required)

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Apr 11, 2023
@alexey-milovidov
Copy link
Member

@rschu1ze backward incompatible change.

@alexey-milovidov
Copy link
Member

I don't think this change will be welcomed by the users of this function (https://metrica.yandex.com/)
Maybe better to update the docs?

@rschu1ze
Copy link
Member Author

Tbh, I find roundAge() a weird function anyways, the boundaries are arbitrary. But if there are users, I agree that we better don't break compatibility. Will adjust the docs.

@rschu1ze rschu1ze merged commit f619208 into master Apr 12, 2023
9 checks passed
@rschu1ze rschu1ze deleted the rs/roundAge branch April 12, 2023 08:32
@rschu1ze rschu1ze changed the title Fix roundAge() Docs: Fix roundAge() Apr 12, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-documentation Documentation PRs for the specific code PR and removed pr-bugfix Pull request with bugfix, not backported by default labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davenger davenger davenger approved these changes

Assignees
No one assigned
Labels
pr-documentation Documentation PRs for the specific code PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roundAge returns incorrect value
5 participants
@rschu1ze @alexey-milovidov @davenger @robot-ch-test-poll @robot-clickhouse-ci-2