Remove -Wshadow suppression which leaked into global namespace
#48737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschu1ze
force-pushed
the
rs/fix-wshadow
branch
from
d7e1ab6
to
7a21d58
Compare
robot-clickhouse-ci-2
added
the
pr-not-for-changelog
serxa
approved these changes
Apr 13, 2023
| @@ -16,9 +16,6 @@ | |||
| #include <Interpreters/IExternalLoadable.h> | |||
|
|
|||
|
|
|||
| /// Clang mistakenly warns about the names in enum class. | |||
| #pragma clang diagnostic ignored "-Wshadow" | |||
|
Finding this was actually pure luck 😄 |
rschu1ze
changed the title
-Wshadow suppression which leaked into global namespace
yokofly
added a commit
to timeplus-io/proton
that referenced
this pull request
Apr 16, 2024
porting ClickHouse/ClickHouse#48737 on Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See "Dictionaries/DictionaryStructure.h", noticed when working on #48671
Changelog category (leave one):