VarInt coding: Always perform sanity check #48740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow-up for the discussion in #48628. The sanity check against VAR_UINT_MAX is now unconditional (independent of the build type). Let's see how that affects performance ... I'll probably add "Unchecked" overloads later on (to avoid clutter they are avoided for now)
rschu1ze
force-pushed
the
rs/varint-sanity
branch
from
8779b3a
to
3e3344d
Compare
robot-clickhouse-ci-1
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up for the discussion in #48628. The sanity check against
VAR_UINT_MAXis now unconditional, i.e. independent of the build type. Let's see how that affects performance. I will probably addUncheckedoverloads later on - for now they are omitted to avoid clutter.Changelog category (leave one):