-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insert UInt32 Hashvalue in reverse order on big endian machine #48764
insert UInt32 Hashvalue in reverse order on big endian machine #48764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is needed for serialized state compatibility, let's do it on ser/de, as it will be more efficient.
Please add a comment in the code with the motivation. |
I am open to any alternative solutions. The problem I see now is that to do it on ser/de, I need to know the index of the hashvalue stored in buf, I can see it is calculated using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable, thank you!
Can someone merge this in, please? |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Fix Hashvalue order on big endian machine
Documentation entry for user-facing changes