Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate definition of SingleEndpointHTTPSessionPool #48779

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Remove duplicate definition of SingleEndpointHTTPSessionPool #48779

merged 2 commits into from
Apr 15, 2023

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Apr 14, 2023 •
edited

The class SingleEndpointHTTPSessionPool is defined as

  • DB::SingleEndpointHTTPSessionPool in HTTPCommon.h
  • DB::(anonymous namespace)::SingleEndpointHTTPSessionPool in HTTPCommon.cpp

And they have different definitions, which may cause unexpected behavior in later code changes

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 14, 2023
@davenger davenger added the can be tested Allows running workflows for external contributors label Apr 14, 2023
@davenger davenger self-assigned this Apr 14, 2023
davenger
davenger reviewed Apr 14, 2023
View reviewed changes
src/IO/HTTPCommon.cpp Outdated Show resolved Hide resolved
@robot-ch-test-poll4 robot-ch-test-poll4 merged commit 1996049 into ClickHouse:master Apr 15, 2023
138 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_duplicated_code branch April 17, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davenger davenger davenger approved these changes

Assignees

@davenger davenger

Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JaySon-Huang @davenger @robot-ch-test-poll4 @robot-clickhouse-ci-2