Process relative path from cache config #48784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavplubix
approved these changes
Apr 14, 2023
robot-ch-test-poll3
added
the
pr-backward-incompatible
:/ |
|
It's an issue with races on fresh setup runners, that aren't in the github API yet. The details are explained in the thread tl;dr: the termination lambda needs additional requests to AWS API, but I am afraid it could make it slower, so it won't fit the hard 2s timeout. I need time to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
If
pathin cache configuration is not empty and is not absolute path, then it will be put in<clickhouse server data directory>/caches/<path_from_cache_config>.