Fix flaky test test_backup_all #48789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-not-for-changelog
vitlibar
force-pushed
the
fix-flaky-test-backup-all
branch
from
eb87e6d
to
39705ee
Compare
vitlibar
commented
Apr 14, 2023
| @@ -1206,10 +1206,27 @@ def test_backup_all(exclude_system_log_tables): | |||
|
|
|||
| exclude_from_backup = [] | |||
| if exclude_system_log_tables: | |||
| system_log_tables = instance.query( | |||
| "SELECT concat('system.', table) FROM system.tables WHERE (database = 'system') AND (table LIKE '%_log')" | |||
There was a problem hiding this comment.
This query didn't work well because these logs tables are created in background so some log tables could be created after this query but before the BACKUP ALL EXCEPT ... query captured a list of tables to backup. And that caused the test to fail. So I decided to just hardcode a whole list of the system log tables.
alexey-milovidov
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category:
Fix flaky test test_backup_all[True].