forbid gwpsan in debug mode to rescue stress tests #48804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll4
added
the
pr-not-for-changelog
|
Ok. I've added a comment. |
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
alexey-milovidov
approved these changes
Apr 16, 2023
azat
reviewed
Jul 8, 2023
| # but GWP-ASan also wants to use mmap frequently, | ||
| # and due to a large number of memory mappings, | ||
| # it does not work together well. | ||
| if ((NOT OS_LINUX AND NOT OS_ANDROID) OR (CMAKE_BUILD_TYPE_UC STREQUAL "DEBUG")) |
There was a problem hiding this comment.
Actually this looks odd, since someone may expect from debug build to have as much checks as possible, instead, maybe it is better to disable it in runtime? i.e.
GWP_ASAN_OPTIONS="Enabled=false"@hanfei1991 what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporarily fix #47646
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes