Prevent a bug in AWS S3 #48816
Merged
Prevent a bug in AWS S3 #48816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-improvement
antonio2368
approved these changes
Apr 16, 2023
antonio2368
reviewed
Apr 16, 2023
Comment on lines
+80
to
+85
|
|
||
| /// AWS S3 SDK library has a bug. It is using std::*stream (which is a major offense). | ||
| /// LLVM libc++ has a bug. It does not allow std::*stream to work for large strings. | ||
|
|
||
| if (max_single_part_upload_size >= 2_GiB) | ||
| throw Exception(ErrorCodes::INVALID_SETTING_VALUE, "Uploading parts of 2 GiB or larger is not supported due to a bug in AWS and LLVM. Lower the value of `s3_max_single_part_upload_size` setting."); |
There was a problem hiding this comment.
just noticed there is validate function for this, auto merge already triggered 🥲
EDIT: requested review again before the job was executed, let's see what will happen
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Apr 17, 2023
Reverts: ClickHouse#48816 Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
If a user set
max_single_part_upload_sizeto a very large value, it can lead to a crash due to a bug in the AWS S3 SDK. This fixes #47679.Note: no tests will be provided for this issue.